-
Notifications
You must be signed in to change notification settings - Fork 32
[fix] Reconcile firewall ref if there is no firewall ID on linode machine #920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tchinmai7
merged 12 commits into
linode:main
from
sammysclub:fix/linode-machine-firewall-ref
Oct 16, 2025
Merged
[fix] Reconcile firewall ref if there is no firewall ID on linode machine #920
tchinmai7
merged 12 commits into
linode:main
from
sammysclub:fix/linode-machine-firewall-ref
Oct 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
==========================================
+ Coverage 66.28% 66.34% +0.06%
==========================================
Files 71 71
Lines 7957 7961 +4
==========================================
+ Hits 5274 5282 +8
+ Misses 2381 2378 -3
+ Partials 302 301 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eljohnson92
reviewed
Oct 15, 2025
eljohnson92
previously approved these changes
Oct 16, 2025
AshleyDumaine
approved these changes
Oct 16, 2025
eljohnson92
approved these changes
Oct 16, 2025
sammysclub
added a commit
to sammysclub/cluster-api-provider-linode
that referenced
this pull request
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: When a linode machine has a firewall ref but no firewall ID, the firewall will not get reattached to the machine if it gets detached (ex: during cluster pivot). Tested using the developer instructions with
make local-deploy
and basic cluster (already has a linodeMachine with a firewallRef and no firewallID)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: