Skip to content

Conversation

sammysclub
Copy link
Contributor

What this PR does / why we need it: When a linode machine has a firewall ref but no firewall ID, the firewall will not get reattached to the machine if it gets detached (ex: during cluster pivot). Tested using the developer instructions with make local-deploy and basic cluster (already has a linodeMachine with a firewallRef and no firewallID)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.34%. Comparing base (50188d8) to head (6c1606b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
+ Coverage   66.28%   66.34%   +0.06%     
==========================================
  Files          71       71              
  Lines        7957     7961       +4     
==========================================
+ Hits         5274     5282       +8     
+ Misses       2381     2378       -3     
+ Partials      302      301       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

eljohnson92
eljohnson92 previously approved these changes Oct 16, 2025
@tchinmai7 tchinmai7 merged commit efc2c2e into linode:main Oct 16, 2025
13 checks passed
@sammysclub sammysclub deleted the fix/linode-machine-firewall-ref branch October 16, 2025 17:37
sammysclub added a commit to sammysclub/cluster-api-provider-linode that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants