Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh node metadata on stale nodes #225

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

shanduur
Copy link
Member

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

Sometimes the metadata might become stale when the node itself is not removed/added or even updated. We need to trigger the update to prevent stale metadata on the nodes.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 55.64%. Comparing base (af045d1) to head (3223a06).
Report is 1 commits behind head on main.

Files Patch % Lines
cloud/linode/node_controller.go 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
- Coverage   56.05%   55.64%   -0.42%     
==========================================
  Files          12       12              
  Lines        1873     1887      +14     
==========================================
  Hits         1050     1050              
- Misses        680      694      +14     
  Partials      143      143              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanduur shanduur merged commit f2b7e2a into linode:main Aug 15, 2024
3 of 5 checks passed
@shanduur shanduur deleted the fix-ttl-node branch August 15, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants