Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-8642] - Migrate Button to UI package #11250

Merged

Conversation

hkhalil-akamai
Copy link
Contributor

Changes 🔄

  • Migrate Button and associated components (Styled[Action|Link|Tag]Button), stories and tests to UI package
  • Migrate keyframe animations
  • Update imports

@hkhalil-akamai hkhalil-akamai self-assigned this Nov 12, 2024
@hkhalil-akamai hkhalil-akamai requested a review from a team as a code owner November 12, 2024 23:00
@hkhalil-akamai hkhalil-akamai requested review from carrillo-erik and coliu-akamai and removed request for a team November 12, 2024 23:00
Copy link

github-actions bot commented Nov 13, 2024

Coverage Report:
Base Coverage: 87.32%
Current Coverage: 87.28%

Copy link
Contributor

@coliu-akamai coliu-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Hussain! 🚀

@coliu-akamai coliu-akamai added the Approved Multiple approvals and ready to merge! label Nov 14, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 445 passing tests on test run #4 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing445 Passing2 Skipped86m 54s

@hkhalil-akamai hkhalil-akamai merged commit c452a0e into linode:develop Nov 15, 2024
8 of 11 checks passed
@hkhalil-akamai hkhalil-akamai deleted the M3-8642-move-Button-to-UI branch November 15, 2024 22:35
Copy link

cypress bot commented Nov 15, 2024

Cloud Manager E2E    Run #6832

Run Properties:  status check passed Passed #6832  •  git commit c452a0ece8: refactor: [M3-8642] - Migrate `Button` to UI package (#11250)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #6832
Run duration 26m 33s
Commit git commit c452a0ece8: refactor: [M3-8642] - Migrate `Button` to UI package (#11250)
Committer Hussain Khalil
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 452
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Modularization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants