-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-8642] - Migrate Button
to UI package
#11250
Merged
hkhalil-akamai
merged 8 commits into
linode:develop
from
hkhalil-akamai:M3-8642-move-Button-to-UI
Nov 15, 2024
Merged
refactor: [M3-8642] - Migrate Button
to UI package
#11250
hkhalil-akamai
merged 8 commits into
linode:develop
from
hkhalil-akamai:M3-8642-move-Button-to-UI
Nov 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkhalil-akamai
requested review from
carrillo-erik and
coliu-akamai
and removed request for
a team
November 12, 2024 23:00
Coverage Report: ❌ |
coliu-akamai
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Hussain! 🚀
packages/manager/src/components/VerticalLinearStepper/VerticalLinearStepper.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesDetail/LinodeBackup/CaptureSnapshot.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesDetail/LinodeBackup/LinodeBackups.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Linodes/LinodesDetail/LinodeStorage/LinodeVolumes.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/Longview/LongviewLanding/LongviewList.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
approved these changes
Nov 14, 2024
Cloud Manager UI test results🎉 445 passing tests on test run #4 ↗︎
|
Cloud Manager E2E Run #6832
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #6832
|
Run duration | 26m 33s |
Commit |
c452a0ece8: refactor: [M3-8642] - Migrate `Button` to UI package (#11250)
|
Committer | Hussain Khalil |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
2
|
Pending |
2
|
Skipped |
0
|
Passing |
452
|
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes 🔄
Button
and associated components (Styled[Action|Link|Tag]Button
), stories and tests to UI package