-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-8833] - Update API types and mock data for VPU plans #11256
Open
coliu-akamai
wants to merge
7
commits into
linode:develop
Choose a base branch
from
coliu-akamai:m3-8833
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coliu-akamai
changed the title
upcoming: [M3-8833] - Update types and mock data for VPU plans
feat: [M3-8833] - Update types and mock data for VPU plans
Nov 14, 2024
coliu-akamai
changed the title
feat: [M3-8833] - Update types and mock data for VPU plans
feat: [M3-8833] - Update API types and mock data for VPU plans
Nov 15, 2024
coliu-akamai
requested review from
bnussman-akamai and
abailly-akamai
and removed request for
a team
November 15, 2024 16:53
coliu-akamai
commented
Nov 15, 2024
@@ -110,7 +110,7 @@ export const resizeLinode = (linodeId: number, data: ResizeLinodePayload) => | |||
* automatically appended to the root user's authorized keys file. | |||
*/ | |||
export const rebuildLinode = (linodeId: number, data: RebuildRequest) => | |||
Request<{}>( | |||
Request<Linode>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(updated this type since this request does return a Linode)
https://techdocs.akamai.com/linode-api/reference/post-rebuild-linode-instance
Coverage Report: ✅ |
Cloud Manager UI test results🎉 445 passing tests on test run #6 ↗︎
|
bnussman-akamai
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Updates api types and mocks data so that Accelerated plans show up when using MSW
Accelerated plans will be hidden behind an account capability - we currently do not plan to use a feature flag
Changes 🔄
Target release date 🗓️
12/10
Preview 📷
How to test 🧪
As an Author, I have considered 🤔
As an Author, before moving this PR from Draft to Open, I confirmed ✅