Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-8741] - Add linter rules for common pr feedback points #11258

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

pmakode-akamai
Copy link
Contributor

Description πŸ“

Highlight the Pull Request's context and intentions.

Changes πŸ”„

List any change(s) relevant to the reviewer.

  • ...
  • ...

Target release date πŸ—“οΈ

Please specify a release date (and environment, if applicable) to guarantee timely review of this PR. If exact date is not known, please approximate and update it as needed.

Preview πŸ“·

Include a screenshot or screen recording of the change.

πŸ”’ Use the Mask Sensitive Data setting for security.

πŸ’‘ Use <video src="" /> tag when including recordings in table.

Before After
πŸ“· πŸ“·

How to test πŸ§ͺ

Prerequisites

(How to setup test environment)

  • ...
  • ...

Reproduction steps

(How to reproduce the issue, if applicable)

  • ...
  • ...

Verification steps

(How to verify changes)

  • ...
  • ...

As an Author, I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Nov 14, 2024
@pmakode-akamai pmakode-akamai changed the title change: [M3-8741] - Add linter rules for common pr feedback points feat: [M3-8741] - Add linter rules for common pr feedback points Nov 14, 2024
@pmakode-akamai pmakode-akamai force-pushed the M3-8741-add-linter-rules-for-common-pr-feedback-points branch from 5b627a3 to e93ddb4 Compare November 15, 2024 11:06
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸŽ‰ 445 passing tests on test run #2 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
0 Failing445 Passing2 Skipped101m 10s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants