Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: [UIE-8261] - Update doc links on db landing page empty state #11262

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rodonnel-akamai
Copy link
Contributor

Description πŸ“

Update doc links on Database landing page empty state

Changes πŸ”„

  • Updated doc links

Target release date πŸ—“οΈ

12/2024

How to test πŸ§ͺ

Prerequisites

  • The showEmpty case needs to be true, which can be manually set in a local env, but which will also be true if there are no new or legacy databases

Reproduction steps

  • The documentation links are on the page that is presented when there are no databases present - i.e. if you see a table of databases, you won't see these links

Verification steps

  • Visit the links to see if they go to the new locations

As an Author, I have considered πŸ€”

  • πŸ‘€ Doing a self review
  • ❔ Our contribution guidelines
  • 🀏 Splitting feature into small PRs
  • βž• Adding a changeset
  • πŸ§ͺ Providing/improving test coverage
  • πŸ” Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • πŸ‘£ Providing comprehensive reproduction steps
  • πŸ“‘ Providing or updating our documentation
  • πŸ•› Scheduling a pair reviewing session
  • πŸ“± Providing mobile support
  • β™Ώ Providing accessibility support

  • [ x] I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed βœ…

  • [ x] All unit tests are passing
  • [ x] TypeScript compilation succeeded without errors
  • [ x] Code passes all linting rules

@rodonnel-akamai rodonnel-akamai requested a review from a team as a code owner November 14, 2024 19:28
@rodonnel-akamai rodonnel-akamai requested review from cpathipa and hkhalil-akamai and removed request for a team November 14, 2024 19:28
Copy link

Coverage Report: βœ…
Base Coverage: 87.34%
Current Coverage: 87.37%

@cpathipa cpathipa removed the request for review from hkhalil-akamai November 14, 2024 21:24
@cpathipa cpathipa added the DBaaS Relates to Database as a Service label Nov 14, 2024
@cpathipa
Copy link
Contributor

@rodonnel-akamai This PR is good to merge once change-set is added.

@jaalah-akamai jaalah-akamai added the Approved Multiple approvals and ready to merge! label Nov 15, 2024
@rodonnel-akamai
Copy link
Contributor Author

rodonnel-akamai commented Nov 15, 2024

@rodonnel-akamai This PR is good to merge once change-set is added.

Forgot that step, just now got around to it and updated the PR.

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

πŸŽ‰ 445 passing tests on test run #2 β†—οΈŽ

❌ Failingβœ… Passingβ†ͺ️ SkippedπŸ• Duration
0 Failing445 Passing2 Skipped86m 47s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! DBaaS Relates to Database as a Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants