-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for updated behavior of linode API's (networkingip, rdns, instance) #1658
Open
AniJ98
wants to merge
64
commits into
linode:dev
Choose a base branch
from
AniJ98:ipreservation-remainingendpoints-final
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional reserved IP to existing linode
… respective tests
…anch before next release
…AniJ98/terraform-provider-linode into ipreservation-existingendpoints
…anch before next release
… tests from being run by unit test targets
… to the latest release
…responding test. Removed unnessary logs
Ipreservation newendpoints
…e_reserved_ip resource
…urce called linode_networking_assign_ip
…NetworkingIP_filterReserved tests
Merging changes from dev into ipreservation-remainingednpoints-final
…n a region and fetching the updated IP address model
…s, removed dummy reserved IP from test functions
AniJ98
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
November 12, 2024 23:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR implements functionality and tests for managing Reserved IP addresses in the Linodego client. These changes align with the updated Linode API, providing comprehensive support for Reserved IP operations. The changes include:
Implementation of core operations:
Test Coverage:
✔️ How to Test
Ensure you have a valid Linode API token. Set up your environment:
export LINODE_TOKEN="your_token_here"
To test the above mentioned functionalities individually :
make int-test PKG_NAME="linode/networkingip" ARGS="-run TestAccResourceNetworkingIP_reserved"
Verify the test output for any failures or unexpected behavior.
Note:
Ensure you have proper permissions and sufficient quota in your Linode account to perform Reserved IP operations. Some tests may create and delete resources, so use a testing environment if possible.