Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add a linting step for all of our custom bitbake recipes #114

Closed
wants to merge 1 commit into from

Conversation

hnez
Copy link
Member

@hnez hnez commented Feb 19, 2024

This PR is inspired by #110, which mentions running meta-openembedded's oe-stylize.py on the bitbakes files in meta-lxatac.

Now that I have learned that there is a linter script for bitbake files I want it as a GitHub action.

So here is a pull request to add it.

TODO before merging:

  • Make sure the action runs without errors

@hnez hnez self-assigned this Feb 19, 2024
@ejoerns
Copy link
Collaborator

ejoerns commented Feb 19, 2024

@hnez While I like the idea in general, I have some objections against running this in CI: The script is not too actively maintained (primarily got some PEP8-related fixes over the last years) and is not part of oe-core. I have seen several false positives I had to re-fix manually in some recipes (like when properly using self-defined variables).

Thus I'd say it is a good tool for running manually on your recipe, but I am not sure if we should enforce it in CI automatically.

@hnez hnez changed the base branch from nanbield to scarthgap July 26, 2024 11:36
@hnez
Copy link
Member Author

hnez commented Jul 26, 2024

I've just rebased the PR, just to have a second look at the output of the job.

On the one hand I really like having one canonical version of source files with their formatting defined by a formatter, on the other hand oe-stylize.py does not seem to be up to the task yet, like rustfmt, prettier or clang-format are.

I will close the PR for now. Maybe some day we will have an appropriate auto-formatter.

@hnez hnez closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants