meta-lxatac-software: tacd: failsafe: gpiofind no longer exists #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jluebbe
requested changes
Dec 18, 2023
hnez
force-pushed
the
tacd-failsafe
branch
2 times, most recently
from
ce034b2
to
178851c
Compare
The gpiofind command was removed, so the tacd-failsafe command would currently fail (which is kind of ironic). Instead gpioset can be directly supplied with the GPIO names. The GPIOs are not guaranteed to keep the assigned value once gpioset exits, so we just keep it running for some time before trying to restart the tacd. Signed-off-by: Leonard Göhrs <[email protected]>
jluebbe
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gpiofind command was removed, so the tacd-failsafe command would currently fail (which is kind of ironic).
Instead gpioset can be directly supplied with the GPIO names. The GPIOs are not guaranteed to keep the assigned value once gpioset exits, so we just keep it running for some time before trying to restart the tacd.