Skip to content

wip: Sketch out hybrid QR transport support #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 3, 2025
Merged

wip: Sketch out hybrid QR transport support #34

merged 6 commits into from
Jun 3, 2025

Conversation

iinuwa
Copy link
Collaborator

@iinuwa iinuwa commented May 25, 2025

  • add GTK changes and QR code lib for UI flow
  • Add handler trait and stream to pull into view model
  • Add dummy hybrid QR handler for demonstrating flow

@AlfioEmanueleFresta
Copy link
Member

LGTM so far (I tried running this)

@iinuwa iinuwa force-pushed the hybrid branch 3 times, most recently from 1b62327 to b359bf4 Compare June 3, 2025 03:34
@iinuwa
Copy link
Collaborator Author

iinuwa commented Jun 3, 2025

This still needs a couple of things:

  • UI updates after receiving BLE advert and after tunnel is established (needs support from libwebauthn)
  • remove some Dummy implementations

There's a weird race condition or something: the UI renders correctly if I add breakpoints, but misses the initial update. I'm wondering if this is some sort of problem with mixing async runtimes. To avoid a big rebase, I'm going to go ahead and merge this in, switch over to Tokio every, and then come back to this.

@iinuwa iinuwa marked this pull request as ready for review June 3, 2025 04:05
@iinuwa iinuwa merged commit ce11c10 into main Jun 3, 2025
1 check passed
@iinuwa iinuwa deleted the hybrid branch June 3, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants