Don't error out because of UxUpdate messages #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
UsbStateInternal::NeedsUserVerification
-case prevented the fallback from fingerprints to PINs, in case UV got blocked by using the wrong finger too often.In general, I don't think we should error out because of
UxUpdates
at all, as libwebauthn should error out properly in case of actual errors in the actual function call (not via the updates channel).With this patch, I'm able to fall back to entering PINs after UV got blocked. However, once PINs get blocked also, the UI doesn't reflect that, but I think this is a general issue right now with propagating/displaying errors of any kind.
Sadly, I didn't have the time to add a fix for that to this PR, too.