Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix most ansible-test issues, suppress the rest #362

Merged
merged 1 commit into from
Apr 9, 2021

Commits on Apr 9, 2021

  1. fix most ansible-test issues, suppress the rest

    Automation Hub, and possibly Galaxy in the future, require the
    collection to be screened with `ansible-test sanity` among other
    checks.  The role had a number of issues:
    * Use `AssertionError` instead of `assert`
    * Use of `logging` module not in accordance with standards, but these
      are ok and the errors were suppressed
    * Several import errors which are ok because they are checked
      elsewhere
    * __init__.py in the module_utils directories must be empty, so a
      new file myerror.py was added to move the code from __init__.py
      * NOTE: network_lsr/nm/__init__.py is not empty
    * The documentation block in the module was not properly constructed
      or formatted.
    * shellcheck issues, including removing unused files
    * use `unused` instead of `_` (underscore) for variables that are
      unused
    
    add WARNING to module docs - collection users should not use directly
    
    Signed-off-by: Rich Megginson <[email protected]>
    richm authored and tyll committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    fa269b1 View commit details
    Browse the repository at this point in the history