Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Ensure lvm pool shared test cleanup #415

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

richm
Copy link
Contributor

@richm richm commented Jan 15, 2024

Save and restore lvm.conf

Put the test in a block, and put all of the cleanup in always.

Signed-off-by: Rich Megginson [email protected]

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90bbfa7) 13.30% compared to head (f372923) 13.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   13.30%   13.30%           
=======================================
  Files           8        8           
  Lines        1781     1781           
  Branches       79       79           
=======================================
  Hits          237      237           
  Misses       1544     1544           
Flag Coverage Δ
sanity 16.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Save and restore lvm.conf

Put the test in a `block`, and put all of the cleanup in `always`.

Signed-off-by: Rich Megginson <[email protected]>
@richm richm merged commit 61c27a1 into linux-system-roles:main Jan 17, 2024
19 checks passed
@richm richm deleted the shared-cleanup branch January 17, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant