-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable GFS2 support in blivet #418
feat: Enable GFS2 support in blivet #418
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 13.30% 13.29% -0.01%
==========================================
Files 8 8
Lines 1781 1782 +1
Branches 79 79
==========================================
Hits 237 237
- Misses 1544 1545 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bc8a1f9
to
cd3dbdc
Compare
This breaks most of the tests. I've run tests on centos-9 and centos-8 and they fail with
|
cd3dbdc
to
4c67043
Compare
Sorry, should be fixed now. |
What is the relationship between |
GFS2 is supported by blivet, but the support is disabled by default so we need to enable it. Fixes: linux-system-roles#417
For existing devices we want to read the default value from the device instead of trying to reset it to default/empty label when the fs_label attribute is not set. Related: linux-system-roles#417
4c67043
to
030258d
Compare
I have added comment explaining this in |
GFS2 is supported by blivet, but the support is disabled by default so we need to enable it.
Fixes: #417