test: skip lvm pool shared test if not supported #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our CI and local test frameworks do not currently support the shared lvm pool test. Skip it by default. If you want to run the test, set the environment variable `SYSTEM_ROLES_STORAGE_SHARED_TEST=true` in your `ansible-playbook` invocation environment e.g. `SYSTEM_ROLES_STORAGE_SHARED_TEST=true ansible-playbook ... tests_lvm_pool_shared.yml` Signed-off-by: Rich Megginson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 16.54% 13.29% -3.25%
==========================================
Files 2 8 +6
Lines 284 1782 +1498
Branches 79 79
==========================================
+ Hits 47 237 +190
- Misses 237 1545 +1308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vojtechtrefny
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI and local test frameworks do not currently support the
shared lvm pool test. Skip it by default.
If you want to run the test, set the environment variable
SYSTEM_ROLES_STORAGE_SHARED_TEST=truein youransible-playbookinvocation environment e.g.SYSTEM_ROLES_STORAGE_SHARED_TEST=true ansible-playbook ... tests_lvm_pool_shared.ymlSigned-off-by: Rich Megginson [email protected]