ci: tox-lsr 3.16.0 - fix qemu tox test failures - rename to qemu-ansible-core-X-Y [citest_skip]

[richm]

the latest version of tox 4.49 has a strange issue - it thinks that a tox testenv
like [qemu-ansible-core-2.20] is specifying python 2.20 which conflicts with the
testenv basepython of python 3.latest. There appears to be no way to workaround this.

So, rename all of the testenvs to use major-minor instead of major.minor e.g.
[qemu-ansible-core-2-20]

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI tox-lsr version and rename qemu/container tox environments to avoid tox 4 python version parsing issues.

Build:

• Bump tox-lsr used in GitHub workflows from 3.15.0 to 3.16.0.

CI:

• Rename qemu and container ansible-core tox environments from dotted to dashed version identifiers across CI workflows to keep qemu tox tests working with newer tox.

Documentation:

• Refresh contributing documentation example to use the new qemu tox environment name format.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CI tox integration to work with tox 4.49 by renaming qemu/container ansible-core tox environments to use dash-separated version identifiers and by bumping the tox-lsr helper to 3.16.0 across workflows and docs.

File-Level Changes

Change	Details	Files
Adjust qemu/container tox environment names to avoid tox 4.49 misinterpreting them as Python version specifiers.	Rename qemu ansible-core tox env names from major.minor to major-minor in the qemu-kvm GitHub Actions matrix. Rename container ansible-core tox env names from major.minor to major-minor in the qemu-kvm GitHub Actions matrix, including commented-out entries for future re-enable.	.github/workflows/qemu-kvm-integration-tests.yml
Update tox-lsr version used in CI workflows to 3.16.0.	Change pip install reference for tox-lsr from 3.15.0 to 3.16.0 in qemu-kvm integration tests workflow. Change pip install reference for tox-lsr from 3.15.0 to 3.16.0 in ansible-lint workflow. Change pip install reference for tox-lsr from 3.15.0 to 3.16.0 in ansible-managed-var-comment workflow. Change pip install reference for tox-lsr from 3.15.0 to 3.16.0 in ansible-test workflow.	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Align contributor documentation with new qemu tox environment naming scheme.	Update example tox command in contributing guide to use the new dash-separated qemu-ansible-core environment name and a current ansible-core version.	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The example tox environment in contributing.md was updated to qemu-ansible-core-2-20, but the CI matrix only uses 2-16/2-17/2-18/2-19; consider aligning the example with an environment that actually exists in the workflows or explicitly documenting 2-20 support elsewhere.
• You are pinning the same tox-lsr@3.16.0 version in multiple workflow files; consider centralizing this (e.g., via a reusable workflow or a single shared action) to make future version bumps less error-prone.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The example tox environment in `contributing.md` was updated to `qemu-ansible-core-2-20`, but the CI matrix only uses 2-16/2-17/2-18/2-19; consider aligning the example with an environment that actually exists in the workflows or explicitly documenting 2-20 support elsewhere.
- You are pinning the same `tox-lsr@3.16.0` version in multiple workflow files; consider centralizing this (e.g., via a reusable workflow or a single shared action) to make future version bumps less error-prone.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}