Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Appstream metadata XML with hardware mapping. #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Added Appstream metadata XML with hardware mapping. #28
Changes from all commits
7846d99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this make
hdapsd
automatically installed on all ThinkPads?I don't think that Thinkpads shipped with rotating disks for the last 10 years, and the ones from the last 5 years probably don't even support rotating disks at all, so it seems wrong to suggest this tool for these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is currently nothing automatically installing it, but yes, the
modalias glob will match all Thinkpads. Perhaps you have a more fitting
match expression? 'cat $(find /sys -name modalias)|sort -u' can provide
some ideas.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the joystick feature only present on machines with a rotating disk, or is that part useful also on Thinkpads with SSD?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The joystick feature?
Are you mixing up hdapsd and tp-smapi?
hdapsd (this repo) is only for parking HDDs and not useful on flash-based storage.
tp-smapi exposes a sensor (also) as a joystick so you can play games by moving the laptop, but the interface it's using doesn't exist since SandyBridge models from 2012.