Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weather@mockturtl 3.4.0 #5396

Merged
merged 12 commits into from
Jan 30, 2024
Merged

weather@mockturtl 3.4.0 #5396

merged 12 commits into from
Jan 30, 2024

Conversation

Gr3q
Copy link
Contributor

@Gr3q Gr3q commented Jan 20, 2024

Changes:

TODO:

  • Update Changelog
  • Test with Cinnamon 3.8
  • Test on Linux Mint 21.3 (with DNS timing issue on boot) - could not replicate, so this was useless

@sagon53
Copy link

sagon53 commented Jan 29, 2024

Test unter Linux Mint 21.3 (mit DNS-Timing-Problem beim Booten) – konnte nicht repliziert werden, daher war dies nutzlos

Auf Deutsch er lässt die leute einfach mit dem bug hängen

@Gr3q
Copy link
Contributor Author

Gr3q commented Jan 30, 2024

@sagon53 I went to google translate with the hopes that someone tested my fix so I will know it will work or I need to work on it more. I was a bit disappointed.

On this note this is just how much free time I have on my hands nowadays. It is clearly not ideal but I can't do much about it.

@Gr3q Gr3q marked this pull request as ready for review January 30, 2024 09:09
@rcalixte
Copy link
Member

@sagon53 I went to google translate with the hopes that someone tested my fix so I will know it will work or I need to work on it more. I was a bit disappointed.

On this not this is just how much free time I have on my hands nowadays. It is clearly not ideal but I can't do much about it.

I'm sure the community is entirely grateful for your contributions, even if not vocal about it. The number of issues shows how popular and meaningful this applet is but popularity is definitely a double-edged sword. Thank you for taking the time to sort this out!

@rcalixte rcalixte merged commit 998744d into linuxmint:master Jan 30, 2024
1 check passed
@Gr3q Gr3q deleted the weather-fixes branch January 30, 2024 10:14
@vajdao
Copy link
Contributor

vajdao commented Jan 30, 2024

@sagon53 I went to google translate with the hopes that someone tested my fix so I will know it will work or I need to work on it more. I was a bit disappointed.

On this note this is just how much free time I have on my hands nowadays. It is clearly not ideal but I can't do much about it.

Nice work there mate I am very thankful for your work and that you managed to fix this issue, and please don't be disappointed, I'm also sure that the whole community is grateful, I myself tried to clone and test this before the pull was done, but I wasn't sure if I'm doing it right, so I didn't wanted to review with false positives to make some nasty chaos here <3
But overall, thanks for this great applet, it's at the top for a good reason: You're doing a great job, be proud of yourself.

"Remember…the Force will be with you, always."

@BillyCroan
Copy link

BillyCroan commented Jan 30, 2024

I'm already running the new code. I appreciate you @Gr3q!

Your thoughtful weather applet is used by tens of thousands of people, every day, all day. It's one of the few pieces of software that is always visible. In front of me any time I'm using the computer. Firefox can't say that. Terminal, Libre Office, Kernel, OpenSSH, I'm thankful all of those exist, those aren't always visible.

Your applet is always there, for tens of thousands, every day, reminding us there's a world outside of the 1920x1200 pixels that confine our work on the computer.

Thank you Attila, You make the world a better place for many!

@UltiWebAlt
Copy link

@Gr3q you jumped right on this and got the fix out quickly. We all very much appreciate your hard work!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants