Skip to content

Commit

Permalink
scsi: libsas: Delete sas_ata_task.retry_count
Browse files Browse the repository at this point in the history
Since libsas was introduced in commit 2908d77 ("[SCSI] aic94xx: new
driver"), sas_ata_task.retry_count is never set, so delete it and the
reference in asd_build_ata_ascb().

Signed-off-by: John Garry <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: Damien Le Moal <[email protected]>
Reviewed-by: Jason Yan <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
  • Loading branch information
johnpgarry authored and martinkpetersen committed Aug 21, 2023
1 parent 44862dc commit 8634449
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/scsi/aic94xx/aic94xx_task.c
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ static int asd_build_ata_ascb(struct asd_ascb *ascb, struct sas_task *task,
flags |= data_dir_flags[task->data_dir];
scb->ata_task.ata_flags = flags;

scb->ata_task.retry_count = task->ata_task.retry_count;
scb->ata_task.retry_count = 0;

scb->ata_task.flags = 0;
}
Expand Down
2 changes: 0 additions & 2 deletions include/scsi/libsas.h
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,6 @@ struct sas_ata_task {
struct host_to_dev_fis fis;
u8 atapi_packet[16]; /* 0 if not ATAPI task */

u8 retry_count; /* hardware retry, should be > 0 */

u8 dma_xfer:1; /* PIO:0 or DMA:1 */
u8 use_ncq:1;

Expand Down

0 comments on commit 8634449

Please sign in to comment.