Immich: display large numbers with suffixes #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because an app plate is quite small, displaying large numbers can be problematic as they collide and cannot be distinguished. This commit fixes this issue by displaying large numbers using fewer characters and ISO suffixes, up to G (giga, 10^9). Here is an example of the problematic behaviour: +-----------------------+ | PHOTOS VIDEOS USAGE | | 14398443 0.94GiB | +-----------------------+ The 14,398 photo count collides with the 443 video count. This commit changes the display to: +-----------------------+ | PHOTOS VIDEOS USAGE | | 15k 443 0.94GiB | +-----------------------+
|
@mvdkleijn may I ask for a code review please? |
|
@yscialom apologies, I've been very busy with another major project. I'll take a look later today. |
|
That's OK, I'm entitled to no SLA :) Thank you for your time. |
|
Two of the four CI workflows failed:
Could someone point me to the right direction :) ? |
mvdkleijn
approved these changes
Jul 22, 2025
github-project-automation
bot
moved this from PRs
to PRs Approved
in Issue & PR Tracker
|
LGTM. The one error is from another app already in the repo, I'll ignore that for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because an app plate is quite small, displaying large numbers can be problematic as they collide and cannot be distinguished.
This commit fixes this issue by displaying large numbers using fewer characters and ISO suffixes, up to G (giga, 10^9).
Here is an example of the problematic behaviour:
The 14,698 photo count collides with the 443 video count.
This commit changes the display to: