#62 symlink in a new /roms path if the user is mounting in paths RO

[thelamer]

Testing through different methods I did not want to break anyones setup unless they are already using ro paths.
This is the most unobtrusive method I could think of.
Looks for a new path /roms/xxx and symlinks them on init.

[LinuxServer-CI]

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.8.3-pkg-10384e5e-dev-aab6d5e6ca153cca48eeb0355448e46e98a96345-pr-65/index.html
https://ci-tests.linuxserver.io/lspipepr/emulatorjs/1.8.3-pkg-10384e5e-dev-aab6d5e6ca153cca48eeb0355448e46e98a96345-pr-65/shellcheck-result.xml

Tag	Passed
amd64-1.8.3-pkg-10384e5e-dev-aab6d5e6ca153cca48eeb0355448e46e98a96345-pr-65	✅
arm64v8-1.8.3-pkg-10384e5e-dev-aab6d5e6ca153cca48eeb0355448e46e98a96345-pr-65	✅

[hermetic-charm]

This doesn't seem to be working for me.

My volumes in my yaml currently look like this:

volumes:
  - /path/to/config:/config
  - /path/to/data:/data
  - /path/to/custom_startup_scripts:/custom-cont-init.d
  - /path/to/roms/psx:/roms/psx:ro
  - /path/to/roms/nes:/roms/nes:ro

I was initially running out of /data/nes etc. but decided to try this out as it would be useful. The roms are still in /data/nes and are still picked up and playable, I put some new ones in /path/to/roms/nes but it does not seem to see anything from the two newly mounted RO volumes.

Also, the docker user has access to /path/to/roms.

[thelamer]

It is a one time thing, you have to init with those paths on the first run to create the proper symlinks:
This checks if they exist and are not symlinks:
https://github.com/linuxserver/docker-emulatorjs/blob/master/root/etc/s6-overlay/s6-rc.d/init-emulatorjs-config/run#L47-L55

You can make them manually though and they will work.

[hermetic-charm]

I did hop into docker exec and see the volume is up and I can see all the new games in the root roms dir, but there is no symlink between it and /data/nes as you suggested. I can make the symlink manually, but shouldn't this be something that happens when I rebuild the image?

[thelamer]

no those directories are mounted in, and I make a point to not mess with peoples setups, it only works on first run.
The logic is not complex.

[hermetic-charm]

Understood, thanks.