Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polishing docs for manual authentication #2863

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frisso
Copy link
Member

@frisso frisso commented Dec 11, 2024

No description provided.

@adamjensenbot
Copy link
Collaborator

Hi @frisso. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@frisso
Copy link
Member Author

frisso commented Dec 11, 2024

To me, there's still a bit of confusion between the terms "pairing" and "peering". We should clarify when to use one, and when to use the other.

@frisso frisso added the docs Updates or adds documentation label Dec 11, 2024
@frisso frisso marked this pull request as draft December 11, 2024 05:33
@frisso
Copy link
Member Author

frisso commented Dec 11, 2024

Waiting for PR #2827 to be merged in order to cleanup also the other sections of the 'manual peering' documentation.

@fra98 fra98 added kind/docs and removed docs Updates or adds documentation labels Dec 11, 2024
@frisso
Copy link
Member Author

frisso commented Dec 12, 2024

/rebase

@adamjensenbot adamjensenbot force-pushed the frs/manual-auth-docs-cleanup branch from 05ac1d9 to 83114dd Compare December 12, 2024 03:40
@fra98 fra98 force-pushed the frs/manual-auth-docs-cleanup branch 3 times, most recently from 4d36b84 to 9ad22a9 Compare December 16, 2024 15:28
@fra98 fra98 force-pushed the frs/manual-auth-docs-cleanup branch from 9ad22a9 to 05c1030 Compare December 20, 2024 12:18
@github-actions github-actions bot added the docs Updates or adds documentation label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Updates or adds documentation size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants