[liqoctl] set gateway server Service location in peer command
#2913
+32
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fra98. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
github-actions
bot
added
feat
fra98
changed the title
fra98
changed the title
peer command
claudiolor
approved these changes
Jan 31, 2025
|
/rebase |
adamjensenbot
force-pushed
the
frt/liqoctl-gw-position
branch
from
91aad33 to
cb2934c
Compare
|
/test |
fra98
force-pushed
the
frt/liqoctl-gw-position
branch
from
cb2934c to
9741cc1
Compare
fra98
changed the title
peer commandpeer command
|
/test |
aleoli
approved these changes
Feb 3, 2025
|
/test |
fra98
force-pushed
the
frt/liqoctl-gw-position
branch
from
9741cc1 to
2048e52
Compare
|
/test |
1 similar comment
|
/test |
fra98
force-pushed
the
frt/liqoctl-gw-position
branch
from
2048e52 to
62f1883
Compare
|
/test |
|
/rebase test=true |
adamjensenbot
force-pushed
the
frt/liqoctl-gw-position
branch
from
62f1883 to
00f95f2
Compare
|
Difficult for me to understand what "server" means in the command line, "--server-service-location". |
frisso
reviewed
Feb 7, 2025
| @@ -36,7 +36,8 @@ To perform a peering without having access to both clusters, you need to manuall | |||
| The peering command enables all 3 liqo modules and performs the following steps: | |||
|
|
|||
| 1. **enables networking**. | |||
| Exchanges network configurations and creates the two **gateways** (server in the provider, client in the consumer) to let the two clusters communicate over a secure tunnel. | |||
| Exchanges network configurations and creates the two **gateways** (one server in a cluster and one client in the other) to let the two clusters communicate over a secure tunnel. | |||
| By default the gateway server in placed in the provider, while the gateway client in the consumer, but you can configure it with the `--server-service-location` flag. | |||
There was a problem hiding this comment.
Suggested change
| By default the gateway server in placed in the provider, while the gateway client in the consumer, but you can configure it with the `--server-service-location` flag. | |
| The location of the client/server gateway can be customized when creating the peering using the `--server-service-location` flag in `liqoctl`. |
frisso
reviewed
Feb 7, 2025
| @@ -36,7 +36,8 @@ To perform a peering without having access to both clusters, you need to manuall | |||
| The peering command enables all 3 liqo modules and performs the following steps: | |||
|
|
|||
| 1. **enables networking**. | |||
| Exchanges network configurations and creates the two **gateways** (server in the provider, client in the consumer) to let the two clusters communicate over a secure tunnel. | |||
| Exchanges network configurations and creates the two **gateways** (one server in a cluster and one client in the other) to let the two clusters communicate over a secure tunnel. | |||
There was a problem hiding this comment.
Suggested change
| Exchanges network configurations and creates the two **gateways** (one server in a cluster and one client in the other) to let the two clusters communicate over a secure tunnel. | |
| Exchanges network configurations and creates the two **gateways** (one acting as _server_ and located in the provider cluster, another acting as _client_ in the consumer cluster) to let the two clusters communicate over a secure tunnel. |
frisso
reviewed
Feb 7, 2025
| @@ -90,8 +91,11 @@ func newPeerCommand(ctx context.Context, f *factory.Factory) *cobra.Command { | |||
|
|
|||
| // Networking flags | |||
| cmd.Flags().BoolVar(&options.NetworkingDisabled, "networking-disabled", false, "Disable networking between the two clusters") | |||
| cmd.Flags().Var(options.ServerServiceLocation, "server-service-location", | |||
| fmt.Sprintf("Location of the service to expose the Gateway Server (%q or %q). Default: %q", | |||
There was a problem hiding this comment.
Not sure I would understand correctly.
I would say this way:
fmt.Sprintf("Cluster that acts as gateway server when setting up the network between two Liqo instances (%q or %q). Default: %q",
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the support to specify the gateway client and server location in a peering.
The
--server-service-locationflag inliqoctl peerallows to place the gateway server service in the provider (default) or consumer.This can be useful if you cannot expose Services (or don't have LB UDP support) in the provider cluster or if the provider is behind a NAT (without going through the manual peering procedure or setting up the networking module individually).