Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[liqoctl] include network init in connect #2918

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

claudiolor
Copy link
Contributor

Description

This PR removes the liqoctl network init command, including its functionalities into connect. This simplifies usage and removes a command which is really unlikely used alone.

@adamjensenbot
Copy link
Collaborator

Hi @claudiolor. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@claudiolor claudiolor force-pushed the clo/remote-liqoctl-init branch from 1b09a13 to 7e83c53 Compare February 5, 2025 18:01
@claudiolor claudiolor changed the title refactor(liqoctl)!: include network init in connect [liqoctl] include network init in connect Feb 5, 2025
@claudiolor claudiolor force-pushed the clo/remote-liqoctl-init branch 2 times, most recently from 31ba8f8 to 28f79dd Compare February 6, 2025 09:47
@github-actions github-actions bot added the refactor Reorganizes or optimizes code without changing its behavior label Feb 6, 2025
pkg/liqoctl/network/cluster.go Outdated Show resolved Hide resolved
docs/advanced/peering/inter-cluster-network.md Outdated Show resolved Hide resolved
@claudiolor claudiolor force-pushed the clo/remote-liqoctl-init branch 3 times, most recently from 35a89d5 to 6535d5b Compare February 7, 2025 14:10
@claudiolor
Copy link
Contributor Author

/test

@fra98
Copy link
Member

fra98 commented Feb 10, 2025

/rebase test=true

This patch removes the `liqoctl network init` command, including its
functionalities into `connect`. This simplifies usage and removes a
command which is really unlikely used alone.
@adamjensenbot adamjensenbot force-pushed the clo/remote-liqoctl-init branch from 6535d5b to 05e1dcb Compare February 10, 2025 15:01
@fra98
Copy link
Member

fra98 commented Feb 10, 2025

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Feb 10, 2025
@adamjensenbot adamjensenbot merged commit 494b978 into liqotech:master Feb 10, 2025
14 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Reorganizes or optimizes code without changing its behavior size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants