Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Network] remap mask #2924

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[Network] remap mask #2924

merged 1 commit into from
Feb 10, 2025
+239 −18

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Feb 7, 2025

Description

This PR fixes the remap mask function and add tests

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the feat Adds a new feature to the codebase label Feb 7, 2025
@github-actions github-actions bot added fix Fixes a bug in the codebase. and removed feat Adds a new feature to the codebase labels Feb 7, 2025
@cheina97 cheina97 linked an issue Feb 7, 2025 that may be closed by this pull request
Unable to access service/ingress to a offloaded pod: 504 Gateway Time-out #2909
Closed
@cheina97 cheina97 mentioned this pull request Feb 7, 2025
Closed
@cheina97 cheina97 force-pushed the frc/remapmask branch 2 times, most recently from e1af400 to a8280b7 Compare February 7, 2025 10:16
@cheina97
Copy link
Member Author

cheina97 commented Feb 7, 2025

/build

@cheina97
Copy link
Member Author

cheina97 commented Feb 7, 2025

/rebase test=true

@cheina97 cheina97 force-pushed the frc/remapmask branch 2 times, most recently from b949a56 to 3082d28 Compare February 7, 2025 10:49
@cheina97
Copy link
Member Author

cheina97 commented Feb 7, 2025

/rebase test=true

@cheina97
Copy link
Member Author

cheina97 commented Feb 7, 2025

/rebase test=true

@cheina97
Copy link
Member Author

/test

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 merged commit c2f889a into liqotech:master Feb 10, 2025
14 checks passed
@cheina97 cheina97 deleted the frc/remapmask branch February 10, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudiolor claudiolor claudiolor approved these changes

@aleoli aleoli Awaiting requested review from aleoli

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
fix Fixes a bug in the codebase. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to access service/ingress to a offloaded pod: 504 Gateway Time-out
3 participants
@cheina97 @adamjensenbot @claudiolor