Skip to content

Conversation

@Deblazz
Copy link

@Deblazz Deblazz commented Aug 10, 2025

fix(common.sh): fixed cgroupDriver configuration to ensure broad OS compatibility in quickstart example

Description

Added explicit selection of cgroupDriver when using create_cluster() function of examples' common.sh.

I had problems running the script on fedora 42, now, by default, systemd is selected ( thus allowing compatibility with fedora ) but can be overridden in case of uncompatible distros.

To override it, explicit it this way when using scripts which use common.sh:

(e.g.)
CGROUP_DRIVER=cgroupfs ./setup.sh

@adamjensenbot
Copy link
Collaborator

Hi @Deblazz. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@github-actions github-actions bot added the fix Fixes a bug in the codebase. label Aug 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes a bug in the codebase. size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants