Skip to content

Conversation

@aleoli
Copy link
Member

@aleoli aleoli commented Aug 20, 2025

Description

This pr extends the Liqo compatibility to Kubernetes providers not supporting the Ed25519 signing algorithm.

Fix #2998

@github-actions github-actions bot added the feat Adds a new feature to the codebase label Aug 20, 2025
@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • feat: 🚀 New Feature
  • fix: 🐛 Bug Fix
  • refactor: 🧹 Code Refactoring
  • docs: 📝 Documentation
  • style: 💄 Code Style
  • perf: 🐎 Performance Improvement
  • test: ✅ Tests
  • chore: 🚚 Dependencies Management
  • build: 📦 Builds Management
  • ci: 👷 CI/CD
  • revert: ⏪ Reverts Previous Changes

@aleoli aleoli force-pushed the aol/tls-rsa branch 3 times, most recently from 492a8bc to 0d19113 Compare August 20, 2025 09:20
@aleoli
Copy link
Member Author

aleoli commented Aug 20, 2025

/test

1 similar comment
@aleoli
Copy link
Member Author

aleoli commented Aug 26, 2025

/test

@aleoli aleoli marked this pull request as ready for review August 27, 2025 08:05
Copy link
Contributor

@claudiolor claudiolor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment on the parameter documentation to make it clear when to use it.
Maybe we can also add a section in the FAQ about this issue.

@aleoli aleoli force-pushed the aol/tls-rsa branch 3 times, most recently from 37d2845 to d47b8f5 Compare August 28, 2025 12:39
@aleoli
Copy link
Member Author

aleoli commented Oct 13, 2025

/test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Adds a new feature to the codebase size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Allow to select CSR signature algorithm

3 participants