-
Notifications
You must be signed in to change notification settings - Fork 128
feat: Direct connection support between provider clusters #3115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gabbe64
wants to merge
8
commits into
liqotech:master
Choose a base branch
from
Gabbe64:no-fcc-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Gabbe64. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
07a8051 to
0c46130
Compare
|
/test |
1 similar comment
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feat
Adds a new feature to the codebase
refactor
Reorganizes or optimizes code without changing its behavior
release-1.1
Feature that is planned to be integrated within a given Liqo release
size/L
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3011
This PR introduces the possibility to make pods deployed on provider clusters communicate directly by using an established network connection (
liqoctl network connect).This feature is opt-in: users can enable it by adding the annotation key
use-direct-connections: trueto theServiceexposing the pods that should communicate directly. This way, the default behavior remains unchanged, while also giving users the possibility to choose whether to route traffic through the consumer cluster or directly.Implementation
As discussed during the last community meetings, the modified components are the virtual-kubelet and the ShadowEndpointslice controller.
Transmission - virtual-kubelet
When reflecting
Endpointslicesand the correspondingServicehas the right annotation, some data is collected from the informers (without direct the API server calls) then serialized as JSON and reflected in the annotation field of theShadowEndpointslice.This data is:
clusterIDwhere the endpoint is deployed,Endpointsliceof the consumer,Reception
The ShadowEndpointslice controller (in the provider cluster) receives this data and uses it to remap the addresses so to use the direct connections towards other provider clusters (if available).
To achieve this:
podCIDR(point 1) and the host part extracted from the local IP (point 2); this required the implementation of a "forced mapping".