[Core] feat: mark foreigncluster as permanently unreachable #3122
+229
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @claudiolor. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
claudiolor
changed the title
Closed
claudiolor
force-pushed
the
clo/force-unpeering
branch
from
7663fd3 to
7ebcae5
Compare
|
/rebase test=true |
adamjensenbot
force-pushed
the
clo/force-unpeering
branch
from
7ebcae5 to
da1528d
Compare
This patch fixes a known issue with Liqo: when a provider cluster becomes unreachable, it is not easy to disable a peering connection with that cluster, as the CRDreplicator and the ControllerManager attempt to remove resources from a cluster that will never come back up. A mechanism based on the `liqo.io/foreign-cluster-permanently-unreachable` has been added: when a ForeignCluster is marked with that annotations, and the API server of the remote cluster is considered unreachable, then replicated resources are removed from the local cluster, ignoring the remote ones.
claudiolor
force-pushed
the
clo/force-unpeering
branch
from
da1528d to
a61dfc4
Compare
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a known issue with Liqo: when a provider cluster becomes unreachable, it is not easy to disable a peering connection with that cluster, as the CRDreplicator and the ControllerManager attempt to remove resources from a cluster that will never come back up. A mechanism based on the
liqo.io/foreign-cluster-permanently-unreachable: truehas been added: when a ForeignCluster is marked with that annotations, and the API server of the remote cluster is considered unreachable, then replicated resources are removed from the local cluster, ignoring the remote ones.