feat: avoid kyverno dependency in tests #3128
Open
+45
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cheina97. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
|
/rebase test=true |
fra98
approved these changes
Sep 22, 2025
cheina97
force-pushed
the
frc/nettestkyverno
branch
from
f721cfc to
773623c
Compare
fra98
approved these changes
Sep 22, 2025
Comment on lines
+48
to
81
| if IsKyvernoAvailable(ctx, cl.ConsumerDynamic) { | ||
| policy := ForgeKyvernoPodAntiaffinityPolicy(cl.ConsumerName, false) | ||
| if _, err := cl.ConsumerDynamic.Resource(KyvernoPolicyGroupVersionResource). | ||
| Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("consumer failed to create policy: %w", err) | ||
| } | ||
|
|
||
| policy = ForgeKyvernoPodAntiaffinityPolicy(cl.ConsumerName, true) | ||
| if _, err := cl.ConsumerDynamic.Resource(KyvernoPolicyGroupVersionResource). | ||
| Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("consumer failed to create policy: %w", err) | ||
| policy = ForgeKyvernoPodAntiaffinityPolicy(cl.ConsumerName, true) | ||
| if _, err := cl.ConsumerDynamic.Resource(KyvernoPolicyGroupVersionResource). | ||
| Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("consumer failed to create policy: %w", err) | ||
| } | ||
| } else { | ||
| kyvernoNotInstalled = true | ||
| printer.Logger.Warn("Kyverno not available on consumer, skipping policy creation.") | ||
| } | ||
|
|
||
| for k := range cl.Providers { | ||
| policy := ForgeKyvernoPodAntiaffinityPolicy(k, false) | ||
| if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource). | ||
| Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("provider %q failed to create policy: %w", k, err) | ||
| } | ||
| policy = ForgeKyvernoPodAntiaffinityPolicy(k, true) | ||
| if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource). | ||
| Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("provider %q failed to create policy: %w", k, err) | ||
| if IsKyvernoAvailable(ctx, cl.ProvidersDynamic[k]) { | ||
| policy := ForgeKyvernoPodAntiaffinityPolicy(k, false) | ||
| if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource). | ||
| Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("provider %q failed to create policy: %w", k, err) | ||
| } | ||
| policy = ForgeKyvernoPodAntiaffinityPolicy(k, true) | ||
| if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource). | ||
| Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) { | ||
| return fmt.Errorf("provider %q failed to create policy: %w", k, err) | ||
| } | ||
| } else { | ||
| kyvernoNotInstalled = true | ||
| printer.Logger.Warn(fmt.Sprintf("Kyverno not available on provider %q, skipping policy creation.", k)) | ||
| } | ||
| } |
There was a problem hiding this comment.
NIT: can we refactor it so that both consumer and providers call the same function, avoiding code duplicates?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the kyverno dependency from network tests.
If kyverno is not installed in one of the tested clusters a warning will be triggered.
In case you are not using kyverno you cannot be sure that all the pods will be scheduled one per node