Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(spring-boot): adding spring boot charts #575

Merged
merged 3 commits into from
Nov 21, 2022

Conversation

ispeakc0de
Copy link
Member

@ispeakc0de ispeakc0de commented Nov 17, 2022

Signed-off-by: Shubham Chaudhary [email protected]

Thanks for the contribution @cazeaux

@neelanjan00
Copy link
Member

Can we remove the .idea/workspace.xml file?

@cazeaux
Copy link

cazeaux commented Nov 17, 2022

Can we remove the .idea/workspace.xml file?

Hello. This has been fixed by a rebase, i guess that the file was coming from master at some point of time.

Signed-off-by: Shubham Chaudhary <[email protected]>
@cazeaux
Copy link

cazeaux commented Nov 18, 2022

Hello

I did not see that it was another PR. Why not use the initial PR ?
#543

@ispeakc0de
Copy link
Member Author

Hello

I did not see that it was another PR. Why not use the initial PR ? #543

Hi @cazeaux, we have changed the initial spring boot experiment. We split it into five separate experiment and simplified the envs as well

@cazeaux
Copy link

cazeaux commented Nov 18, 2022

Ho I see.
I am not totally aligned with this approach. I agree that it simplifies, but you kind of lose the ability to have multiple assaults on a same pod. By separating them, you make them exclusive.
Chaos Monkey for Spring Boot is super interesting to have several assaults in parallele (latency + exception for example).
Maybe we can keep one additional chart for this ?

@ispeakc0de
Copy link
Member Author

ispeakc0de commented Nov 18, 2022

Ho I see. I am not totally aligned with this approach. I agree that it simplifies, but you kind of lose the ability to have multiple assaults on a same pod. By separating them, you make them exclusive. Chaos Monkey for Spring Boot is super interesting to have several assaults in parallele (latency + exception for example). Maybe we can keep one additional chart for this ?

Thanks for the suggestion @cazeaux . Yes, it makes sense, added an additional chart for this

@ispeakc0de ispeakc0de merged commit f41ae89 into litmuschaos:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants