feat: improve kube api usage and reduce unnecessary reconciliations #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdsoumya
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
gdsoumya
force-pushed
the
feat/improve_performance
branch
from
d41e1a6 to
6053971
Compare
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
gdsoumya
force-pushed
the
feat/improve_performance
branch
4 times, most recently
from
5f7e583 to
66fd812
Compare
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
gdsoumya
force-pushed
the
feat/improve_performance
branch
from
66fd812 to
2cf36e1
Compare
ispeakc0de
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes exporter logic to use informer cache and workqueues to reduce the no. of api calls made to kube api server and also reduce unnecessary metrics are refreshes.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
documentationtagbreaking-changestagrequires-upgradetag