-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added myHub Api tests #363
Conversation
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Aman Dwivedi <[email protected]>
Cypress/cypress/support/commands.js
Outdated
"project_id": project2Id, | ||
"user_id": user2Id | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can logout user2 here also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!, PTAL on minor comments as discussed.
Signed-off-by: Aman Dwivedi <[email protected]>
@Jonsy13 Changes added in last commit:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!..LGTM
Proposed changes
Summarize your changes here to communicate with the reviewers and make sure to put the link of the related issue
How has this been tested:
Types of changes
What types of changes does your code introduce to Litmus? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Documentation
Code Review
Special notes for your reviewer:
Out of 23 tests 17 tests passed and 6 tests failed. The six failing tests are:
These tests will pass after the appropriate fix are merged (Tracked on #362)
cc @Jonsy13