Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create auth api tests for user endpoints #364

Merged
merged 3 commits into from
Feb 16, 2022
Merged

create auth api tests for user endpoints #364

merged 3 commits into from
Feb 16, 2022

Conversation

Aman-Codes
Copy link
Contributor

@Aman-Codes Aman-Codes commented Feb 14, 2022 •
edited
Loading

Proposed changes

Summarize your changes here to communicate with the reviewers and make sure to put the link of the related issue

How has this been tested:

  • Test environment
    • GKE
    • AWS
    • OpenShift
    • KinD/k3s/k3d cluster
    • Others
  • Tested with production environment ( For ChaosCenter Tests )
  • Have not tested

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • I have added necessary documentation (if appropriate)
  • I have added Screenshots or Terminal snippets in the PR comment to validate the successful execution of changes

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • data-cy=* parameters have been added in codebase ( ChaosCenter Tests )
  • data-cy=* parameters need to be added in codebase ( ChaosCenter Tests )
  • No updates required.

Special notes for your reviewer:

Contains tests for user related apis. The findings from this test are reported at #362 .
cc @Jonsy13
image

@Jonsy13 Jonsy13 self-requested a review February 16, 2022 05:08
SarthakJain26
SarthakJain26 approved these changes Feb 16, 2022
View reviewed changes
Copy link

@SarthakJain26 SarthakJain26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Checks on status code from response can also be added

@Aman-Codes
add status code checks
7ba7e48 
Signed-off-by: Aman Dwivedi <[email protected]>
Saranya-jena
Saranya-jena requested changes Feb 16, 2022
View reviewed changes
Cypress/cypress/integration/Api_Tests/authentication/user.spec.js Outdated
}).then((res) => {
expect(res.body).to.have.property("error");
expect(res.body).to.have.property("error_description");
expect(res.body.error).to.eq("unauthorized");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a constant for the error: unauthorized and use it everywhere? It will be easy to maintain the error messages in the future.

@Aman-Codes
Copy link
Contributor Author

@SarthakJain26 @Saranya-jena Thanks for the review, added the requested changes (status code checks and constants for error codes).

@Saranya-jena
Copy link

LGTM, thank you for the efforts 🚀

@Jonsy13 Jonsy13 requested a review from Saranya-jena February 16, 2022 08:35
@Jonsy13 Jonsy13 merged commit bcbebee into litmuschaos:master Feb 16, 2022
@Aman-Codes Aman-Codes deleted the userSpec branch February 16, 2022 12:15
neelanjan00 pushed a commit to neelanjan00/litmus-e2e that referenced this pull request May 2, 2022
@Aman-Codes @neelanjan00
create auth api tests for user endpoints (litmuschaos#364)
5f8b25c 
* create auth api tests for user endpoints

Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Neelanjan Manna <[email protected]>
uditgaurav pushed a commit that referenced this pull request May 13, 2022
@neelanjan00 @Jonsy13 @Aman-Codes
m-agent Pipeline with Process-Kill Experiment Tests (#374)
c7455dc 
* Fixed the failing tests (#365)

Signed-off-by: Jonsy13 <[email protected]>
Signed-off-by: Neelanjan Manna <[email protected]>

* create auth api tests for user endpoints (#364)

* create auth api tests for user endpoints

Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Neelanjan Manna <[email protected]>

* added m-agent process-kill pipeline and BDD test cases

Signed-off-by: neelanjan00 <[email protected]>
Signed-off-by: Neelanjan Manna <[email protected]>

* changed vm zone

Signed-off-by: Neelanjan Manna <[email protected]>

* updated charts

Signed-off-by: Neelanjan Manna <[email protected]>

* updated yaml syntax

Signed-off-by: Neelanjan Manna <[email protected]>

* added nightly pipeline; renamed experiment pipeline

Signed-off-by: Neelanjan Manna <[email protected]>

* renamed experiment pipeline

Signed-off-by: Neelanjan Manna <[email protected]>

* corrected yaml format

Signed-off-by: Neelanjan Manna <[email protected]>

* create auth api tests for project endpoints (#366)

Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Neelanjan Manna <[email protected]>

* updated gcloud sdk setup action version

Signed-off-by: Neelanjan Manna <[email protected]>

* updated the zones

Signed-off-by: Neelanjan Manna <[email protected]>

* updated command for matrix and pid

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug echo

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug echo to normal pipeline

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug

Signed-off-by: Neelanjan Manna <[email protected]>

* removed line breaks

Signed-off-by: Neelanjan Manna <[email protected]>

* added sleep

Signed-off-by: Neelanjan Manna <[email protected]>

* removed line break

Signed-off-by: Neelanjan Manna <[email protected]>

* used jq for parsing json

Signed-off-by: Neelanjan Manna <[email protected]>

* updated command syntax

Signed-off-by: Neelanjan Manna <[email protected]>

* added KUBECONFIG env

Signed-off-by: Neelanjan Manna <[email protected]>

* added EOF and added gcloud sdk

Signed-off-by: Neelanjan Manna <[email protected]>

* added EOF and added gcloud sdk

Signed-off-by: Neelanjan Manna <[email protected]>

* added PROCESS_IDS env

Signed-off-by: Neelanjan Manna <[email protected]>

* updated sleep to 30s

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug steps

Signed-off-by: Neelanjan Manna <[email protected]>

* replaced jq with grep

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug step

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug step

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug step

Signed-off-by: Neelanjan Manna <[email protected]>

* added debug step

Signed-off-by: Neelanjan Manna <[email protected]>

* updated set-output steps

Signed-off-by: Neelanjan Manna <[email protected]>

* used artifactory to upload and download secrets

Signed-off-by: Neelanjan Manna <[email protected]>

* added artifact debug step

Signed-off-by: Neelanjan Manna <[email protected]>

* reordered download artifact step

Signed-off-by: Neelanjan Manna <[email protected]>

* split serial and parallel tests

Signed-off-by: Neelanjan Manna <[email protected]>

* corrected syntax

Signed-off-by: Neelanjan Manna <[email protected]>

* segregated delete vm job

Signed-off-by: Neelanjan Manna <[email protected]>

* added missing gcloud setup step

Signed-off-by: Neelanjan Manna <[email protected]>

* added chaos workflow related tests (#370)

* added chaos workflow related tests

Signed-off-by: Aman Dwivedi <[email protected]>

* updated cluster tests

Signed-off-by: Aman Dwivedi <[email protected]>
Signed-off-by: Neelanjan Manna <[email protected]>

* updated nightly pipeline

Signed-off-by: Neelanjan Manna <[email protected]>

* updated outputs, removed debug steps

Signed-off-by: Neelanjan Manna <[email protected]>

Co-authored-by: Vedant Shrotria <[email protected]>
Co-authored-by: Aman Dwivedi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarthakJain26 SarthakJain26 SarthakJain26 approved these changes

@Jonsy13 Jonsy13 Jonsy13 approved these changes

@Saranya-jena Saranya-jena Saranya-jena approved these changes

Assignees

@Aman-Codes Aman-Codes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Aman-Codes @Saranya-jena @Jonsy13 @SarthakJain26