DNS Chaos - Format TargetHostnames String For dns_interceptor Binary #750
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR creates a function under stringutils which takes comma separated targetHostnames string as input and return formatted string which is expected by dns_interceptor binary
This removes manual effort from the user to enter a string with correct formatting
For example
experiment.targetHostnames = "Alice, Bob, Charlie" (string entered by user)
FormatHostnames(experiment.targetHostnames) = "["Alice", "Bob", "Charlie"]" (as expected by dns_interceptor binary)
As of now the experiment fails when a comma separated string value is passed from ChaosCenter.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
breaking-changes
tagrequires-upgrade
tag