refactor: replace strings with constant values #39
+213
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
namkyu1999
approved these changes
Dec 15, 2024
Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
|
Hi @seedspirit, Can you replace strings in invitation endpoints to constant value? |
Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
|
@jemlog I realized I missed the invitation api. Made commit to reflect it |
|
LGTM! |
namkyu1999
requested changes
Dec 17, 2024
| // this.token = response.getAccessToken(); | ||
| // return response; | ||
| // } | ||
| public String authenticate(LoginRequest request) |
There was a problem hiding this comment.
could you make a token class instead of returing string? it's for maintanence
Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
Signed-off-by: BoGyum Kim | 김보겸 <[email protected]>
namkyu1999
requested changes
Dec 23, 2024
| private final LitmusHttpClient httpClient; | ||
| private final LitmusGraphQLClient graphQLClient; | ||
|
|
||
| public LitmusClient(String host, String token) { | ||
| public LitmusClient(String host, LitmusAuthToken token) { |
There was a problem hiding this comment.
Suggested change
| public LitmusClient(String host, LitmusAuthToken token) { | |
| public LitmusClient(String host, String token) { |
Can you get token as string and make like below?
this.token = new ListAuthToken(token);
| // } | ||
| public LitmusAuthToken authenticate(LoginRequest request) | ||
| throws IOException, LitmusApiException { | ||
| LoginResponse response = httpClient.post(LOGIN, request, LoginResponse.class); |
There was a problem hiding this comment.
Is this code actually working?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced all strings to constant values. String constants values are located in io/litmuschaos/constants directory