Analytics for litmus portal. #2065

ishangupta-ds · 2020-09-14T06:50:03Z

Proposed changes

Adds analytics section and fixes for the same to litmus portal.

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

New feature (non-breaking change which adds functionality)
Bugfix (non-breaking change which fixes an issue)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

I have read the CONTRIBUTING doc
I have signed the commit for DCO to be passed.
Lint and unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added necessary documentation (if appropriate)

Dependency

None.

Special notes for your reviewer:

Analytics PR #3

Signed-off-by: ishangupta-ds <[email protected]>

…lytics table. Signed-off-by: ishangupta-ds <[email protected]>

Signed-off-by: ishangupta-ds <[email protected]>

arkajyotiMukherjee · 2020-09-14T15:53:13Z

litmus-portal/frontend/src/pages/AnalyticsPage/index.tsx

-    { variables: { projectID: selectedProjectID } }
+    {
+      variables: { projectID: selectedProjectID },
+      fetchPolicy: 'cache-and-network',


remove this...not required here

arkajyotiMukherjee · 2020-09-14T15:55:13Z

litmus-portal/frontend/src/pages/AnalyticsPage/index.tsx

    };

    workflowRuns.push(edgeLow);
    workflowRuns.push(workflowRunOnce);
    workflowRuns.push(edgeHigh);

    setWorkflowRunDataForPlot(workflowRuns);
-  }, [data]);
+  }, [data, loading]);


loading is not required here as a dependency...remove this

Suggested change

}, [data, loading]);

}, [data]);

arkajyotiMukherjee · 2020-09-14T15:57:27Z

litmus-portal/frontend/src/pages/AnalyticsPage/index.tsx

+      }
+    });
+    setSelectedWorkflowRunDetails(workflowTestsArray);
+  }, [selectedWorkflowRunID, data, loading]);


Suggested change

}, [selectedWorkflowRunID, data, loading]);

}, [selectedWorkflowRunID, data]);

arkajyotiMukherjee · 2020-09-14T16:04:21Z

litmus-portal/frontend/src/views/ChaosWorkflows/BrowseAnalytics/CustomStatus/Status.tsx

@@ -0,0 +1,43 @@
+import React, { useEffect } from 'react';


avoid naming components as Custom

change it to a more apt name

arkajyotiMukherjee · 2020-09-14T16:05:58Z

litmus-portal/frontend/src/views/ChaosWorkflows/BrowseAnalytics/CustomStatus/Status.tsx

+      return setLabel(classes.passed);
+    }
+    return setLabel(classes.failed);
+  }, [status, classes.failed, classes.passed]);


classes can be removed as a dependency

arkajyotiMukherjee · 2020-09-14T16:13:41Z

...s-portal/frontend/src/views/ChaosWorkflows/BrowseAnalytics/WorkflowComparisonTable/styles.ts

+  palette: {
+    secondary: {
+      light: '#FFFFFF',
+      main: '#FFFFFF',


It is required @arkajyotiMukherjee do i move it to theme file?

arkajyotiMukherjee · 2020-09-14T16:17:37Z

...s-portal/frontend/src/views/ChaosWorkflows/BrowseAnalytics/WorkflowComparisonTable/styles.ts

+  },
+
+  calIcon: {
+    color: 'rgba(0, 0, 0, 0.4)',


try this @ishangupta-ds

arkajyotiMukherjee · 2020-09-14T16:18:50Z

...s-portal/frontend/src/views/ChaosWorkflows/BrowseAnalytics/WorkflowRunDetailsTable/index.tsx

+    getTests(processedWorkflowRunDetails);
+    getTestResults(processedWorkflowRunDetails);
+    setReload(true);
+  }, [data, loading, workflowID, reload]);


Suggested change

}, [data, loading, workflowID, reload]);

}, [data, workflowID, reload]);

arkajyotiMukherjee · 2020-09-14T16:20:39Z

...s-portal/frontend/src/views/ChaosWorkflows/BrowseAnalytics/WorkflowRunDetailsTable/index.tsx

+    setReload(true);
+  }, [data, loading, workflowID, reload]);
+
+  useEffect(() => {


filter is a state variable it'll automatically recalculate this. no need for useEffect here

I am updating the selection options dynamically upon changing he filter @arkajyotiMukherjee , if i don't use useEffect() how should i call the functions to update the drop down lists for test and test results?

this is basic concept of state in react...we have done the same in browse workflow
filter is a state var. hence when it changes react will rerender the component where it is used...no need of useEffect

That is good but I am calling 3 functions PTAL, how do I call them without use effect? If I don't use this hook those functions will never be called... getTests() and getTestResults()

arkajyotiMukherjee · 2020-09-14T16:22:38Z

...l/frontend/src/views/ChaosWorkflows/BrowseAnalytics/WorkflowRunDetailsTable/TableToolbar.tsx

+}
+
+interface TestResultCallBackType {
+  (testResult: string): void;


improve this callback situation wherever it is used

Actually its more a state passing function than callback, have named it a callback as it functions similarly.. @arkajyotiMukherjee Not actually using any callback..

Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds · 2020-09-14T16:46:10Z

@arkajyotiMukherjee PTAL. cc: @rajdas98

Changes made.

arkajyotiMukherjee · 2020-09-14T17:15:55Z

...s-portal/frontend/src/views/ChaosWorkflows/BrowseAnalytics/WorkflowRunDetailsTable/index.tsx

+    setReload(true);
+  }, [data, loading, workflowID, reload]);
+
+  useEffect(() => {


this is basic concept of state in react...we have done the same in browse workflow
filter is a state var. hence when it changes react will rerender the component where it is used...no need of useEffect

Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds · 2020-09-14T17:38:52Z

changes made PTAL @arkajyotiMukherjee @rajdas98

Changes made.

ishangupta-ds · 2020-09-14T17:47:52Z

/preview 10
ERROR IN CI

Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds · 2020-09-14T17:54:59Z

/run-unit

Test Status: The testing has been started please wait for the results ...
Test Result: All tests are passed
Run ID: 254295145

Signed-off-by: ishangupta-ds <[email protected]>

Adds Analytics section and fixes for the same to litmus portal. Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds added 4 commits September 14, 2020 10:47

Basic table for analytics.

2590e5c

Signed-off-by: ishangupta-ds <[email protected]>

Merge remote-tracking branch 'upstream/master' into pr3

4940746

Removed notifications, model updated for analytics and integrated ana…

d31e4d1

…lytics table. Signed-off-by: ishangupta-ds <[email protected]>

Resolved conflicts.

4ce2ff3

Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds added WIP state/dev-in-progress DO NOT MERGE area/litmus-portal labels Sep 14, 2020

ishangupta-ds added this to the 1.8 milestone Sep 14, 2020

ishangupta-ds requested a review from amityt September 14, 2020 06:50

ishangupta-ds assigned amityt and ishangupta-ds Sep 14, 2020

ishangupta-ds added kind/bug-fix kind/feature labels Sep 14, 2020

Merge remote-tracking branch 'upstream/master' into pr3

b8f48ba

ishangupta-ds marked this pull request as draft September 14, 2020 06:51

ishangupta-ds added 8 commits September 14, 2020 17:12

Analytics integration.

0bafacb

Signed-off-by: ishangupta-ds <[email protected]>

Merge remote-tracking branch 'upstream/master' into pr3

2fac2c6

Minor fix.

bc73da1

Signed-off-by: ishangupta-ds <[email protected]>

style fixes.

b4b5594

Signed-off-by: ishangupta-ds <[email protected]>

Component fixes.

8435eb0

Signed-off-by: ishangupta-ds <[email protected]>

All style fixed.

45d7321

Signed-off-by: ishangupta-ds <[email protected]>

Fixes made.

00a73cc

Signed-off-by: ishangupta-ds <[email protected]>

Merge remote-tracking branch 'upstream/master' into pr3

79b84b9

ishangupta-ds added state/dev-complete state/review-in-progress and removed DO NOT MERGE WIP state/dev-in-progress labels Sep 14, 2020

ishangupta-ds marked this pull request as ready for review September 14, 2020 14:32

arkajyotiMukherjee previously requested changes Sep 14, 2020

View reviewed changes

Changes after review.

cc81757

Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds requested a review from arkajyotiMukherjee September 14, 2020 16:45

arkajyotiMukherjee previously requested changes Sep 14, 2020

View reviewed changes

Changes after review.

d46dea9

Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds requested a review from arkajyotiMukherjee September 14, 2020 17:38

arkajyotiMukherjee previously approved these changes Sep 14, 2020

View reviewed changes

Minor fix.

6f0998c

Signed-off-by: ishangupta-ds <[email protected]>

amityt previously approved these changes Sep 14, 2020

View reviewed changes

ishangupta-ds dismissed stale reviews from amityt and arkajyotiMukherjee via 6f0998c September 14, 2020 17:52

amityt previously approved these changes Sep 14, 2020

View reviewed changes

arkajyotiMukherjee previously approved these changes Sep 14, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into pr3

05579c6

ishangupta-ds added merge state/review-complete and removed state/review-in-progress labels Sep 14, 2020

Minor style fix.

a8e30cf

Signed-off-by: ishangupta-ds <[email protected]>

ishangupta-ds dismissed stale reviews from arkajyotiMukherjee and amityt via a8e30cf September 14, 2020 18:07

ishangupta-ds requested review from arkajyotiMukherjee and amityt September 14, 2020 18:08

imrajdas merged commit d433a35 into litmuschaos:master Sep 14, 2020

imrajdas pushed a commit to imrajdas/litmus that referenced this pull request Sep 14, 2020

Analytics for litmus portal. (litmuschaos#2065)

2a81070

Adds Analytics section and fixes for the same to litmus portal. Signed-off-by: ishangupta-ds <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Analytics for litmus portal. #2065

Analytics for litmus portal. #2065

ishangupta-ds commented Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

ishangupta-ds Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

ishangupta-ds Sep 14, 2020 •

edited

Loading

arkajyotiMukherjee Sep 14, 2020

ishangupta-ds Sep 14, 2020 •

edited

Loading

arkajyotiMukherjee Sep 14, 2020

ishangupta-ds Sep 14, 2020 •

edited

Loading

ishangupta-ds commented Sep 14, 2020

arkajyotiMukherjee Sep 14, 2020

ishangupta-ds commented Sep 14, 2020

ishangupta-ds commented Sep 14, 2020 •

edited by imrajdas

Loading

ishangupta-ds commented Sep 14, 2020 •

edited by github-actions bot

Loading

	}, [selectedWorkflowRunID, data, loading]);
	}, [selectedWorkflowRunID, data]);

	}, [data, loading, workflowID, reload]);
	}, [data, workflowID, reload]);

Analytics for litmus portal. #2065

Analytics for litmus portal. #2065

Conversation

ishangupta-ds commented Sep 14, 2020

Proposed changes

Types of changes

Checklist

Dependency

Special notes for your reviewer:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishangupta-ds Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishangupta-ds Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishangupta-ds Sep 14, 2020 • edited Loading

Choose a reason for hiding this comment

ishangupta-ds commented Sep 14, 2020

Choose a reason for hiding this comment

ishangupta-ds commented Sep 14, 2020

ishangupta-ds commented Sep 14, 2020 • edited by imrajdas Loading

ishangupta-ds commented Sep 14, 2020 • edited by github-actions bot Loading

ishangupta-ds Sep 14, 2020 •

edited

Loading

ishangupta-ds Sep 14, 2020 •

edited

Loading

ishangupta-ds Sep 14, 2020 •

edited

Loading

ishangupta-ds commented Sep 14, 2020 •

edited by imrajdas

Loading

ishangupta-ds commented Sep 14, 2020 •

edited by github-actions bot

Loading