Support for PHP 8.4 #192
Merged
Support for PHP 8.4 #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Before making this PR I did run the GH action on my fork and I verified that my PHP 8.4 project now works well with this fork. Not sure what additional verifications I should do @DonCallisto. |
jdmaguire
commented
Mar 11, 2025
| fail-fast: false | ||
| matrix: | ||
| php-versions: [ '7.4', '8.0', '8.1'] | ||
| php-versions: [ '7.4', '8.0', '8.1', '8.2', '8.3', '8.4'] |
Contributor
Author
There was a problem hiding this comment.
As an observation, we've been using fastest with PHP 8.3 for months with no issues.
The only hiccup occurring with 8.4 because of the deprecation around implicit nullable types.
DonCallisto
reviewed
Mar 11, 2025
DonCallisto
reviewed
Mar 11, 2025
Collaborator
|
Thank you @jdmaguire 🍺 |
Contributor
Author
|
Thank you too. 🍺 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently upgrading a PHP 8.3 application to PHP 8.4.
This dependency was causing a failure because of a new deprecation in PHP 8.4.
The preferred approach for PHP is to use explicitly nullable types (introduced in PHP 7.1).