Skip to content

feat: add blaze voicebot plugin#5050

Open
HoangPN711 wants to merge 9 commits intolivekit:mainfrom
Actable-AI:feat/blaze-voicebot-plugin
Open

feat: add blaze voicebot plugin#5050
HoangPN711 wants to merge 9 commits intolivekit:mainfrom
Actable-AI:feat/blaze-voicebot-plugin

Conversation

@HoangPN711
Copy link

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Copy link
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

View 11 additional findings in Devin Review.

Open in Devin Review

Comment on lines +47 to +49
auth_token: str = Field(
default="",
description="Bearer token for API authentication",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”΄ Environment variable name mismatch: BLAZE_API_TOKEN documented but BLAZE_AUTH_TOKEN is what pydantic-settings reads

The BlazeConfig class defines its auth field as auth_token and uses env_prefix = "BLAZE_" (_config.py:67). Pydantic-settings v2 constructs env var names as env_prefix + field_name, so it will look for BLAZE_AUTH_TOKEN. However, the README (README.md:30), the __init__.py module docstring (__init__.py:28), and the BlazeConfig class docstring (_config.py:22) all document the env var as BLAZE_API_TOKEN. Users following the documentation will set BLAZE_API_TOKEN, which will be silently ignored β€” the field will fall back to its default empty string "", causing authentication failures that are hard to diagnose.

Suggested change
auth_token: str = Field(
default="",
description="Bearer token for API authentication",
api_token: str = Field(
default="",
description="Bearer token for API authentication",
)
Open in Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

Comment on lines +47 to +49
auth_token: str = Field(
default="",
description="Bearer token for API authentication",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ”΄ Field rename auth_token β†’ api_token must be propagated to all usages

If the field is renamed from auth_token to api_token (to fix BUG-0001), all references to self._config.auth_token and self._auth_token in the plugin code must be updated. These references exist in stt.py:103, tts.py:98, llm.py:94, and the update_options methods in all three files. Alternatively, if the field is kept as auth_token, the README, __init__.py docstring, and _config.py docstring must all be updated to say BLAZE_AUTH_TOKEN.

Prompt for agents
After renaming the field in _config.py from auth_token to api_token, update all references throughout the plugin:

1. In livekit-plugins/livekit-plugins-blaze/livekit/plugins/blaze/stt.py line 103: change self._config.auth_token to self._config.api_token
2. In livekit-plugins/livekit-plugins-blaze/livekit/plugins/blaze/tts.py line 98: change self._config.auth_token to self._config.api_token
3. In livekit-plugins/livekit-plugins-blaze/livekit/plugins/blaze/llm.py line 94: change self._config.auth_token to self._config.api_token

Also update the docstring in _config.py line 22 to say BLAZE_API_TOKEN (it already does, so just verify it stays correct after renaming).
Open in Devin Review

Was this helpful? React with πŸ‘ or πŸ‘Ž to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants