Skip to content

bump manylinux to manylinux_2_34 #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

theomonnom
Copy link
Member

@theomonnom theomonnom commented Mar 10, 2025

see https://github.com/pypa/manylinux

+ glibc 2.34
+ Debian 12+
+ Ubuntu 21.10+
+ Fedora 35+
+ CentOS/RHEL 9+

- glibc 2.28 
- Debian 10+
- Ubuntu 18.10+
- Fedora 29+
- CentOS/RHEL 8+

For reference, it seems like Debian 12 glibc is 2.36 by default.
https://packages.debian.org/source/bookworm/glibc

Latest Raspberry PI OS (Bookworm) runs Debian 12

Copy link
Contributor

ilo-nanpa bot commented Mar 10, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@theomonnom theomonnom requested review from a team, typester and davidzhao March 10, 2025 22:25
Copy link
Member

@typester typester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on the change itself — thanks 👍

Just wondering: are we okay with dropping compatibility with older systems that don't support glibc 2.34?

Personally, I’m not sure we really need to bump the version yet — is there any specific benefit you have in mind?

@davidzhao
Copy link
Member

does this bring about any benefits? as a SDK, it'd be ideal if we are not raising the requirement for OS versions too aggressively.

folks in server environments can be slow to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants