-
Notifications
You must be signed in to change notification settings - Fork 86
bump manylinux to manylinux_2_34 #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to
refer to the manpage for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on the change itself — thanks 👍
Just wondering: are we okay with dropping compatibility with older systems that don't support glibc 2.34?
Personally, I’m not sure we really need to bump the version yet — is there any specific benefit you have in mind?
does this bring about any benefits? as a SDK, it'd be ideal if we are not raising the requirement for OS versions too aggressively. folks in server environments can be slow to update. |
see https://github.com/pypa/manylinux
For reference, it seems like Debian 12 glibc is 2.36 by default.
https://packages.debian.org/source/bookworm/glibc
Latest Raspberry PI OS (Bookworm) runs Debian 12