Skip to content

Allow passing in TLS configuration #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ConradIrwin
Copy link
Contributor

This change makes it possible for users of the library to pass their own TLS

It also bumps to the latest tokio-tungstenite so that the version of rustls in
use matches what we are using at Zed.

We've been through a number of different possible rustls connectors, and we're
currently using one (rustls-platform-verifier) that doesn't have feature flags
in livekit or tungstenite yet.

Instead of requiring that every transitive dependency supports the rustls feature flags we need,
it's much easier to pass only the __rustls-tls feature flag and pass the Connector
that we create with our configuration down the stack.

The main disadvantage of this approach is that if you use the __rustls-tls
flag, and don't pass a Connector, you get a panic when connecting to a wss://
URL.

Copy link
Contributor

ilo-nanpa bot commented Mar 21, 2025

it seems like you haven't added any nanpa changeset files to this PR.

if this pull request includes changes to code, make sure to add a changeset, by writing a file to .nanpa/<unique-name>.kdl:

minor type="added" "Introduce frobnication algorithm"

refer to the manpage for more information.

@ConradIrwin ConradIrwin force-pushed the tls-config-2 branch 2 times, most recently from 4526e6a to 220fd8e Compare March 21, 2025 03:29
@davidzhao davidzhao requested review from typester and theomonnom April 5, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant