Support passing and handling SIP headers. #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennwc
force-pushed
the
update-proto
branch
2 times, most recently
from
6d95e4a to
ad7b595
Compare
davidzhao
reviewed
Sep 14, 2024
pkg/sip/client.go
Outdated
| log := c.log.WithValues( | ||
| log := c.log | ||
| if req.ProjectId != "" { | ||
| log = log.WithValues("project", req.ProjectId) |
There was a problem hiding this comment.
Suggested change
| log = log.WithValues("project", req.ProjectId) | |
| log = log.WithValues("projectID", req.ProjectId) |
There was a problem hiding this comment.
I think I've seen it spelled project in another repository. Will find that place and will update it too then 👍
dennwc
force-pushed
the
update-proto
branch
from
ad7b595 to
d4b5575
Compare
paulwe
approved these changes
Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support passing and handling SIP headers. Also makes tests more robust and fixes integration tests on Mac.
Requires livekit/protocol#805, livekit/livekit#2993