Implement TransferParticipant using SIP REFER messages #182
Conversation
pkg/sip/inbound.go
Outdated
| return err | ||
| } | ||
|
|
||
| select { |
There was a problem hiding this comment.
Could we move this deeper into the call stack? Current function calls c.cc.transferCall which calls sendRefer->sipResponse, which in turn will select on a SIP transaction. So it could also wait on the context and maybe on referDone too? The reason I'm proposing this is that tx may also accept CANCEL requests, which is also exposed as a channel. You will likely need to select on that eventually too, together with referDone.
There was a problem hiding this comment.
I moved this one step down into the stack into sipInbound. I believe this belong to a transaction level above sipResponse, as we are waiting for the a totally separate request (vs STATUS responses). We should handle CANCEL by sending an appropriate error the referDone channel, I believe.
No description provided.