fix #338 support nooption for input and output

livingbio · Jan 16, 2025 · 12447d8 · 12447d8
1 parent 997592b
commit 12447d8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/ffmpeg/dag/io/tests/__snapshots__/test_input/test_input.json b/src/ffmpeg/dag/io/tests/__snapshots__/test_input/test_input.json
@@ -7,6 +7,7 @@
   "-accurate_seek",
   "-display_rotation",
   "1.0",
+  "-nodisplay_vflip",
   "-i",
   "input.mp4",
   "output.mp4"

diff --git a/src/ffmpeg/dag/io/tests/__snapshots__/test_output/test_output.json b/src/ffmpeg/dag/io/tests/__snapshots__/test_output/test_output.json
@@ -5,6 +5,7 @@
   "-c",
   "copy",
   "-shortest",
+  "-noforce_fps",
   "-ar",
   "44100",
   "output.mp4"

diff --git a/src/ffmpeg/dag/nodes.py b/src/ffmpeg/dag/nodes.py
@@ -351,7 +351,8 @@ def get_args(self, context: DAGContext = None) -> list[str]:
             if isinstance(value, bool):
                 if value is True:
                     commands += [f"-{key}"]
-                # NOTE: the -nooption is not supported
+                elif value is False:
+                    commands += [f"-no{key}"]
             else:
                 commands += [f"-{key}", str(value)]
         commands += ["-i", self.filename]
@@ -398,7 +399,8 @@ def get_args(self, context: DAGContext = None) -> list[str]:
             if isinstance(value, bool):
                 if value is True:
                     commands += [f"-{key}"]
-                # NOTE: the -nooption is not supported
+                elif value is False:
+                    commands += [f"-no{key}"]
             else:
                 commands += [f"-{key}", str(value)]
         commands += [self.filename]
@@ -453,7 +455,6 @@ def get_args(self, context: DAGContext = None) -> list[str]:
                     commands += [f"-{key}"]
                 elif value is False:
                     commands += [f"-no{key}"]
-                # NOTE: the -no{key} format since not really for global options
             else:
                 commands += [f"-{key}", str(value)]
         return commands