rubicon: Check whether referenced file exists on .dud rejection #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise rejecting fails for .dud files that reference non-existent files. Signed-off-by: Sebastian Krzyszkowiak <[email protected]>
|
I was looking into this, but wasn't sure whether just ignoring the issue was the correct approach. Since we only ignore stuff upon rejection, I'll merge this and add the log message and comment post-merge, since this PR has been sitting around for a bit too long (sorry for that, life was beating me down hard :-/). Thank you for the patch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise rejecting fails for .dud files that reference non-existent files.