Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/master'
Browse files Browse the repository at this point in the history
  • Loading branch information
Rémy NOËL committed Nov 20, 2023
2 parents c4ea8d1 + c099e82 commit d0f18f8
Show file tree
Hide file tree
Showing 5 changed files with 31 additions and 13 deletions.
21 changes: 10 additions & 11 deletions .github/ISSUE_TEMPLATE/bug_report.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,29 +10,28 @@ assignees: ''
**Package version**


**Environment**
- OS: [e.g. iOS/Windows/...]
- Browser [e.g. chrome, safari]

**Describe the bug**

A clear and concise description of what the bug is.

Add your record configuration `RecordConfig(...)`

**To Reproduce**

Steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

**Expected behavior**
A clear and concise description of what you expected to happen.

**Desktop (please complete the following information):**
- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

**Smartphone (please complete the following information):**
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]
A clear and concise description of what you expected to happen.

**Additional context**

Add any other context about the problem here.
16 changes: 16 additions & 0 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
on:
issues:
types: [opened, edited]

jobs:
auto_close_issues:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v1
- name: Automatically close issues that don't follow the issue template
uses: lucasbento/[email protected]
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
issue-close-message: "@${issue.user.login}: \n\nThis issue is being automatically closed because it does not follow the issue template. Fix it to automatically re-open the issue."
closed-issues-label: "Not following issue template"
3 changes: 3 additions & 0 deletions record_web/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 1.0.3
* fix: Regression on chrome based browsers when numChannels don't match size of inputs.

## 1.0.2
* feat: Add acceptable resampling (up and down) feature for browsers that don't support it natively.

Expand Down
2 changes: 1 addition & 1 deletion record_web/assets/js/record.worklet.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class RecorderProcessor extends AudioWorkletProcessor {

const input = inputs[0]

if (input.length != this._numChannels) {
if (input.length == 0) {
// Sometimes, Firefox doesn't give any input. Skip this frame to not fail.
return true
}
Expand Down
2 changes: 1 addition & 1 deletion record_web/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: record_web
description: Web specific implementation for record package called by record_platform_interface.
version: 1.0.2
version: 1.0.3
homepage: https://github.com/llfbandit/record/tree/master/record_web

environment:
Expand Down

0 comments on commit d0f18f8

Please sign in to comment.