Skip to content

[CIR] Backport support zero init attr for all FP types #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2025

Conversation

AmrDeveloper
Copy link
Member

Update getZeroInitAttr to cover more FP types, Backport from (llvm/llvm-project#133100)

@AmrDeveloper
Copy link
Member Author

cc. @andykaylor

@andykaylor
Copy link
Collaborator

Can you add the test cases from global-var-simple.cpp to exercise these?

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding a testcase

@bcardosolopes bcardosolopes merged commit 8bcd07c into llvm:main Apr 4, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants