Skip to content

[CIR][ThroughMLIR] Add TanOp Lowering #1540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 4, 2025

Conversation

goxul
Copy link
Contributor

@goxul goxul commented Apr 1, 2025

Adds implementation for TanOp's lowering via ThroughMLIR.

@goxul goxul marked this pull request as draft April 1, 2025 08:41
@goxul goxul changed the title Implementation for TanOp in CIR [CIR][ThroughMLIR] Add TanOp Lowering #1530 Apr 1, 2025
@goxul goxul changed the title [CIR][ThroughMLIR] Add TanOp Lowering #1530 [CIR][ThroughMLIR] Add TanOp Lowering Apr 1, 2025
@goxul
Copy link
Contributor Author

goxul commented Apr 1, 2025

Hey @bcardosolopes , I am a new contributor to this project, and I've created a small PR to get the hang of things.

Similar to the PRs here, here, I implemented a lowering for Tan (which I saw was missing). I'll add the lit test for it soon. Couple of questions:

  1. Is there some form of formatter that I need to run before I check-in the code?
  2. Is there any other test that I need to add, other than the lit test?

Thanks!

@bcardosolopes
Copy link
Member

Hi, thanks for the PR

Is there some form of formatter that I need to run before I check-in the code?

Yes, you need to use clang-format, code style in https://llvm.org/docs/CodingStandards.html

Is there any other test that I need to add, other than the lit test?

A lit test is enough for this PR, please add one!

@bcardosolopes
Copy link
Member

After you add the test please move this out of draft!

Copy link

github-actions bot commented Apr 1, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@goxul goxul force-pushed the tan-through-mlir branch from 5f6d773 to 3355c61 Compare April 2, 2025 02:56
@goxul goxul marked this pull request as ready for review April 2, 2025 14:59
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bcardosolopes bcardosolopes merged commit df158bf into llvm:main Apr 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants