[CIR] Treat cir.record class and struct types equivalently. #1564
+1
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create a `cir.record` type, we track the `RecordKind` according to whether the source code declared the type using `struct` or `class` even though these are semantically equivalent. The distinction is used in naming the type when we lower to the LLVM dialect. This change updates the code to remove the last place where we were handling class and struct records differently.
andykaylor
requested review from
bcardosolopes,
erichkeane,
lanza,
dkolsen-pgi and
sitio-couto
bcardosolopes
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a
cir.recordtype, we track theRecordKindaccording to whether the source code declared the type usingstructorclasseven though these are semantically equivalent. The distinction is used in naming the type when we lower to the LLVM dialect.This change updates the code to remove the last place where we were handling class and struct records differently.