[CIR] Fix load alignment #1640
Merged
[CIR] Fix load alignment #1640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an explicit alignment to load instructions where needed in order to make CIR load alignment consistent with classic codegen.
andykaylor
requested review from
xlauko,
bcardosolopes,
mmha,
erichkeane and
lanza
andykaylor
commented
May 22, 2025
| auto loadOp = | ||
| builder.CIRBaseBuilderTy::createLoad(loc, Ptr, isVolatile, isNontemporal); | ||
| if (mlir::isa<cir::VoidType>(eltTy)) | ||
| addr = addr.withElementType(builder, builder.getUIntNTy(8)); |
There was a problem hiding this comment.
Note that the code I'm replacing here used a bitcast to a signed i8. An unsigned i8 seemed more appropriate for a void pointer, but the only test that hits this case (pointer-arith-ext.c) doesn't check for the type.
bcardosolopes
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit alignment to load instructions where needed in order to make CIR load alignment consistent with classic codegen.
As with aligned stores, I have updated tests that were failing with wildcard checks for cir.load, except where alignment was being specifically checked. Where tests failed because of changed alignment, I verified that the new alignment matches what is produced by classic codegen.
The new test for proper alignment behavior is align-load.c.